[email protected] add support for std::format #6651
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hello @Vertexwahn, @c8ef, modules you maintain (spdlog) have been updated in this PR. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a new version 1.16.0.bcr.2 for spdlog to introduce support for std::format via a use_fmt build flag. The changes look good and correctly implement the feature toggle using select() in the BUILD.bazel file and test both configurations in presubmit.yml. I've found a couple of minor issues in the presubmit.yml file related to formatting and consistency that could affect presubmit jobs. Please see my comments for details.
|
@bazel-io skip_check unstable_url |
bazel-io
added
the
skip-url-stability-check
bazel-io
left a comment
bazel-io
left a comment
There was a problem hiding this comment.
All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.
bazel-io
dismissed stale reviews from Vertexwahn and themself
Require module maintainers' approval for newly pushed changes.
meteorcloudy
added
the
presubmit-auto-run
Head branch was pushed to by a user without write access
bazel-io
dismissed
meteorcloudy’s stale review
Require module maintainers' approval for newly pushed changes.
|
Hi @meteorcloudy @bazelbuild/bcr-maintainers, could you have a look at why the CI is failing for the intel macos machine? |
|
@mutalibmohammed I think that was just a temporary error (Error in download: java.io.IOException: Error downloading [file:/Users/buildkite/builds/bk-macos-intel-hsll/bazel/bcr-presubmit/modules/spdlog/1.16.0.bcr.2/MODULE.bazel] to /private/var/tmp/_bazel_buildkite/9d3aed0c624f300002dc845796c6aa9b/external/spdlog+/MODULE.bazel: /private/var/tmp/_bazel_buildkite/9d3aed0c624f300002dc845796c6aa9b/external/spdlog+/MODULE.bazel (Permission denied) Please reabase your PR and push again - lets see if this happens again |
…nd integrity checks
mutalibmohammed
force-pushed
the
mutalib/spdlog/use_std_format
branch
from
8c0c87b to
0a5da04
Compare
|
@Vertexwahn Thanks for the suggestion. Can I get an approval again? |
bazel-io
left a comment
bazel-io
left a comment
There was a problem hiding this comment.
All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.
bazel-io
added
the
auto-merged
4 participants
This PR adds support to use
std::formatavailable in C++20 onwards with spdlog.Added a
use_fmtflag to allow users to usestd::formatinstead offmt.